[tcgc] spread behavior change #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadelesh
requested review from
lmazuel,
m-nash,
iscai-msft,
srnagar and
joheredi
as code owners
microsoft-github-policy-service
bot
added
the
lib:tcgc
|
All changed packages have been documented.
Show changes
|
tadelesh
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
You can try these changes here
|
XiaofeiCao
reviewed
Aug 16, 2024
iscai-msft
approved these changes
Aug 16, 2024
|
@ArcturusZhang @joheredi please review and check if it could satisfy your language's requirement, thanks. |
|
Do we have a dev version so that we could see if this change could meet our requirement? |
before this pr merge, you could use the ci build artifact. after merge, you could use the dev version. |
|
@ArcturusZhang have you tried this in .net emitter? if all behavior is good, could you approve this pr? |
weidongxu-microsoft
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use original model for body parameter in
SdkServiceOperationif it is from a simple spread.simple spread means spread model without any
@header,@queryor@pathproperty and the spread model is the only source of http body.examples,
op test(...Model): void;op test(@header h: string, @query q: string, ...Model): void;these two operation will have
Modelas body parameter.this operation will have an anonymous model with only
propproperty and generated nameTestRequestas body parameter.resolve: #1132
cc: @ArcturusZhang @joheredi
MIGRATION GUIDE
In previous version, we could easily judge if a body type is spread by:
Now, since the spread model could also be used by other operations, you need to change to the following judgement: